[Bug] Siteroot and basePath don't work with routes

Environment

• System: OS: macOS Mojave 10.14.3 CPU: (8) x64 Intel® Core™ i7-4870HQ CPU @ 2.50GHz Memory: 2.77 GB / 16.00 GB Shell: 3.2.57 - /bin/bash
• Binaries: Node: 11.12.0 - /usr/local/bin/node Yarn: 1.15.2 - /usr/local/bin/yarn
• Browsers: Chrome: 73.0.3683.103
• npmPackages: react: ^16.8.2 => 16.8.6 react-color: ^2.17.0 => 2.17.0 react-dom: ^16.8.2 => 16.8.6 react-static: ^7.0.0 => 7.0.5 react-static-plugin-reach-router: ^7.0.0 => 7.0.0 react-static-plugin-sitemap: ^7.0.0 => 7.0.0 react-static-plugin-source-filesystem: ^7.0.0 => 7.0.0 npmGlobalPackages: react-static: 7.0.7

Steps to Reproduce the problem

• react-static create

with “basic” template

• In static.config.js

import path from "path";

export default {
  siteRoot: "http://localhost:3000",
  basePath: "dist",
  // maxThreads: 1, // Remove this when you start doing any static generation
  plugins: [
    [
      require.resolve("react-static-plugin-source-filesystem"),
      {
        location: path.resolve("src/pages")
      }
    ],
    require.resolve("react-static-plugin-reach-router"),
    require.resolve("react-static-plugin-sitemap")
  ]
};

• yarn build && serve . -p 3000

• Go to “http://localhost:3000/dist”

Expected Behavior

Template example should work normally with its routes

Problem

It doesn’t, console show 404 error for loading ressources, path is incorrect.

[gbrsales]

I proposed a fix in PR #1196.

[Vinnl]

Same here, can be seen on a live site here.

Console output of failed requests:

Links appear to point to the correct page, but then error out when clicked.

And indeed, the template tags appear wrong:

My debugging info:

$ npx envinfo --system --npmPackages react* --binaries --npmGlobalPackages react* --browsers
  System:
    OS: Linux 4.15 Ubuntu 18.04.2 LTS (Bionic Beaver)
    CPU: (4) x64 Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz
    Memory: 555.84 MB / 7.52 GB
    Container: Yes
    Shell: 5.4.2 - /bin/zsh
  Binaries:
    Node: 10.15.3 - ~/.nvm/versions/node/v10.15.3/bin/node
    Yarn: 1.15.2 - /usr/bin/yarn
    npm: 6.4.1 - ~/.nvm/versions/node/v10.15.3/bin/npm
  Browsers:
    Chrome: 74.0.3729.108
    Firefox: 66.0.3
  npmPackages:
    react: ^16.8.6 => 16.8.6 
    react-dom: ^16.8.6 => 16.8.6 
    react-ga-donottrack: ^1.0.0 => 1.0.0 
    react-hot-loader: ^4.8.4 => 4.8.4 
    react-markdown: ^4.0.8 => 4.0.8 
    react-static: ^7.0.9 => 7.0.9 
    react-static-plugin-sass: ^7.0.8 => 7.0.8 
    react-static-plugin-typescript: ^7.0.8 => 7.0.8 
    react-syntax-highlighter: ^10.2.1 => 10.2.1