2.x: @CheckReturnValue for public API

How do you guys feel if the @CheckReturnValue annotation was added to certain public API methods?

The one that would probably benefit the most in my opinion would be the subscribe method where you get a Subscription or Disposable back. In 99% of the cases you want to handle it.

Also static analyze tools such as Error Prone could emit an error / warning.

[autonomousapps]

Ugh. After updating to RxJava 2.1.12, I have awful yellow warning highlighting everywhere. My two cents – I hate @CheckReturnValue. I do the following, which works well for my project:

.doOnSubscribe(subscriptions::add) // subscriptions is a CompositeDisposable

I find this much more readable than

Disposable disposable = somethingService.get().subscribe(...);
composititeDisposable.add(disposable);

I don’t want to suppress that warning everywhere, so now I have to litter my code with local suppressions.

[drakeet]

I love the @CheckReturnValue, but in some projects with RxLifecycle we do not actually need to care about this return value. In this case, we have to use suppress everywhere, 🤔…

P.S. I finally found a perfect solution: https://github.com/uber/AutoDispose