assertSubscribed() always passes no matter how many times a Flowable is subscribed to.

Hi,

Perhaps I’ve misunderstood the purpose of this API method, but the javadoc for assertSubscribed() that it should only pass if the Flowable has been subscribed to. However it seems to pass for me even if I don’t subscribe, eg the following passes:

Flowable.fromArray(1, 2).test().assertSubscribed();

It also suggests that it will pass if you only subscribe once, so the following test case should also fail, but seems to pass:

final Flowable<Integer> flowable = Flowable.fromArray(1, 2);
        flowable.subscribe();
        flowable.subscribe();
        flowable.test().assertSubscribed();

I’ve tested this in both rxjava 2.1.1 and 2.0.1.

[JakeWharton]

Calling test() calls subscribe automatically and returns the TestSubscriber. This would only then return false in this case of a broken Flowable that never called the onSubscribe method of the Subscriber.

On Fri, Jul 7, 2017 at 1:23 PM Richard Warburton [e-mail] wrote:

Hi,

Perhaps I’ve misunderstood the purpose of this API method, but the javadoc for assertSubscribed() that it should only pass if the Flowable has been subscribed to. However it seems to pass for me even if I don’t subscribe, eg the following passes:

Flowable.fromArray(1, 2).test().assertSubscribed();

It also suggests that it will pass if you only subscribe once, so the following test case should also fail, but seems to pass:

final Flowable<Integer> flowable = Flowable.fromArray(1, 2); flowable.subscribe(); flowable.subscribe(); flowable.test().assertSubscribed();

I’ve tested this in both rxjava 2.1.1 and 2.0.1.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ReactiveX/RxJava/issues/5474, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEQRwIw5Ex8Ai1VGgWI3RWlZlVlkTks5sLmmFgaJpZM4ORNwN .

[RichardWarburton]

Hi gents,

Thanks for your replies. I was aware of the big picture stuff here but I hadn’t put the implications together in my own mind. Thanks for clarifying the situation. I think the javadoc change you suggested would help confusion around the “subscribe once” aspect as well. I’ll close this issue.

regards,

Richard