Completable missing lambda-subscibe() w/ onSubscribe parameter to provide Disposable

Completable does not have a lambda subscribe() method that provides a Disposable via an onSubscribe parameter, equivalent to the one implemented in Observable:

public final Disposable subscribe(
                    Consumer<? super T> onNext,
                    Consumer<? super Throwable> onError,
                    Action onComplete,
                    Consumer<? super Disposable> onSubscribe)

[akarnokd]

I guess we can start creating issues marked with Design and 3.x so we don’t forget these.

[HolySamosa]

@artem-zinnatullin Whoops, I guess I never hit the “Comment” button on my earlier reply.

Thanks for the suggestions, I can certainly work with them. And it looks like there is a plan to resolve the consistency issue in v3.

This is somewhat of a related tangent, but I wanted to get your thoughts before making a new issue. I think the documentation should make it clear that use of the .doOnSubscribe() should be avoided to acquire a Disposable for purposes of disposing / unsubscribing from the Rx chain. I had been doing this until I ran into an issue with dispose() not working as expected and after a fair amount of digging I discovered this SO answer by @akarnokd which schooled me in the error of my ways.