Rename method Subscriptions.create for semantic clarity.

The Subscriptions.create method is extremely useful but poorly named. Is there a reason that it does not have a more semantic name which emphasizes the nature of the action being for unsubscribe rather than on subscribe?

When you read code like this:

subscription.add(Subscriptions.create(() -> runnable.run()));

it is not at all apparent that this code is for unsubscription.

Something along the lines of unsubscribeAction, withUnsubscribeAction, or doOnUnsubscribe would add a ton of clarity to the readability of this code.

subscription.add(Subscriptions.unsubscribeAction(() -> runnable.run()));
subscription.add(Subscriptions.withUnsubscribeAction(() -> runnable.run()));
subscription.add(Subscriptions.doOnUnsubscribe(() -> runnable.run()));

Now I realize we can’t just rename this method, so I am proposing it as an addition along with deprecation of the original.

[JakeWharton]

That changes nothing about the naming of the method and that it’s a poor choice.

On Wed, Jun 1, 2016, 10:15 PM Artem Zinnatullin [e-mail] wrote:

Well, yeah. But after realizing that the only job of Subscription is to give an api to unsubscribe something and check if it’s already unsubscribed it becomes much more obvious.

interface Subscription { void unsubscribe(); boolean isUnsubscribed(); }

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ReactiveX/RxJava/issues/2967#issuecomment-223178104, or mute the thread https://github.com/notifications/unsubscribe/AAEEEXP94S4xf3_D7j6tjb0AdQInhR09ks5qHjzQgaJpZM4EhPDD .

[akarnokd]

I’m closing this issue due to inactivity. If you have further input on the issue, don’t hesitate to reopen this issue or post a new one. Better yet, you can propose a PR for 2.x about the name change if you wish.