Could Subscription.add() method accept multiple tear down functions at once?

RxJS version: 5.*

Actual behavior:

I often find myself adding multiple Subscriptions into a single Subscription so I can later unsubscribe with a single unsubscribe() call (for example in Angular).

This means I need to do for example the following:

const subscription = new Subscription();

const sub1 = Observable...subscribe();
const sub2 = Observable...subscribe();
const sub3 = Observable...subscribe();

subscription.add(sub1);
subscription.add(sub2);
subscription.add(sub3);

...

subscription.unsubscribe();

Desired behavior:

It would be helpful to me if I could add all tear down functions into subscription at once. For example similarly to Array.push() function that accepts multiple items:

subscription.add(sub1, sub2, sub3);

[larrifax]

I recently discovered that sub.add(another) doesn’t return sub, but another. This means that chaining can have adverse effects if one of the chained subscriptions ends before the root subscription does:

const sub = new Rx.Subscription();

sub
  .add(Rx.Observable.interval(1000).do(x => console.log("Interval 1", x)).first().subscribe())
  .add(Rx.Observable.interval(1000).do(x => console.log("Interval 2", x)).subscribe());

setTimeout(() => sub.unsubscribe(), 5000);

In this case, “Interval 2” never logs to the console, as “Interval 1” effectively unsubscribes “Interval 2” when it ends due to the first() operator.

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.