shareReplay not cleaning up subscriptions.

RxJS version: 5 or 6

Code to reproduce:

const source = interval(1000).pipe(
  tap(() => console.log('tick'),
  shareReplay(1),
);

const sub = source.subscribe(x => console.log(x));

sub.unsubscribe();

Expected behavior:

It should never log “tick”

Actual behavior:

It TOTALLY logs “tick”.

Additional information:

shareReplay should definitely not recycle the underlying ReplaySubject when refCount drops to 0 due to unsubscription. However, it should end the subscription, which it’s currently not doing, because I’m a dolt.

It should be an easy fix.

[intellix]

This workaround was given to me in gitter as I cried that my teardown was never run:

const timer$ = Rx.Observable.timer(0, 500)
  .multicast(x => new Rx.ReplaySubject(1))
  .refCount();

The publishReplay(1).refCount() above with a timer emitted a weird result when subscribed to with 0 refs (it initially gave the last result and then started fresh)

[d3lm]

@ksaldana1 You can use publishReplay(1).refCount() as an alternative for the time being.