question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

PR #494

  • Resolve imported proptypes and types (#464)
  • Add support for enabling import feature in cli
  • Migrate to TS 🎉
  • Migrate from ast-types to babel toolchain. We use estree AST for historic reasons and it is only used internally and in external resolvers/handlers. So switching to babel (non-estree) AST has several advantages:
    • We are not dependent on ast-types anymore, which seems barely maintained
    • We can use all new syntax features in babel out-of-the-box, before estree has decided how to represent the syntax in the AST spec
    • Potentially performance improvement, because the estree plugin in the babel parser is additional work, which gets eliminated.
    • Big Downside and Breaking Change is that probably all custom handlers/resolvers will need an update.
    • Related: #569, #570
    • PR: #638
  • Include #475 tests now that ast-types is gone.
  • Maybe new API for resolvers and handlers which allows checking for correct react-docgen version.
    • While working on the babel migration it became clear this has to be done
    • Thinking about a new API object being passed to resolvers and handlers with traverse(), parser(), and more
    • Also a new FileObject that holds source code and options so we do not need to attach them to the AST.
    • in PR: #638
  • Maybe allow multiple resolvers aka ChainResolver. For example should allow to find one exported component (first resolver) OR any @nnotated component (second resolver).
  • Integrate new resolver to find @nnotated components (https://github.com/Jmeyering/react-docgen-annotation-resolver) https://github.com/Jmeyering/react-docgen-annotation-resolver/issues/29
  • Implement changes from https://github.com/nerdlabs/react-docgen-displayname-handler
  • Migrate from Travis to GH Actions
  • Split into two packages react-docgen & react-docgen-cli, removes unnecessary dependencies if you do not need the cli
  • Migrate from commander to yargs or update commander
  • Rename master branch to main
  • Create MIGRATE.md
  • Create tests for TODOs in code
  • add react-bootstrap to benchmark
  • try new version in react-styleguidist

Post-Release:

  • New website with playground and also documentation about APIs and configuration as well as examples. Not sure what system to use for this, but I guess there are some good website/docu frameworks, similar to what jest/reactjs/babel is using.

If you want to help feel free to comment. I’m nearly done with the first two tasks, which is the biggest chunk of work here so far.

If there are other ideas for major changes feel free to suggest. Now is the right time.

Issue Analytics

  • State:open
  • Created 2 years ago
  • Reactions:7
  • Comments:7

github_iconTop GitHub Comments

4reactions
jquensecommented, Dec 30, 2021

@danez if you wanted to make a set of issues or list of things to still be done on those conversions I may have time to jump in and work on some as well

3reactions
danezcommented, Mar 19, 2022

A quick update: I tried splitting up the first task but it somehow is all pretty intertwined.

  • Switching to babel from ast-types but not yet changing to a non-estree-AST does not work because babel can only handle non-estree-ASTs.
  • Switching to a non-estree-AST but not yet to babel does not work, because ast-types stops working and is not able to build a proper scope tree.

What I figured now is that I can slowly rebuild some features before continuing the migrating to babel. This way most blockers can probably be removed before I can continue the migration. #569 and #570 are the first two PRs that remove builders from ast-types for example.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Download .NET 6.0 (Linux, macOS, and Windows) - Microsoft
NET 6.0 downloads for Linux, macOS, and Windows. .NET is a free, cross-platform, open-source developer platform for building many different types of ...
Read more >
Google Play Store 6.0.0 (noarch) (nodpi) (Android 2.3+)
Google Play Store 6.0.0 (noarch) (nodpi) (Android 2.3+) APK Download by Google LLC - APKMirror Free and safe Android APK downloads.
Read more >
Spring Framework 6.0.0-RC3 available now
Spring Framework 6.0.0-RC3 includes 22 fixes and improvements. This is the last release candidate expected before the general availability ...
Read more >
Release Notes for MongoDB 6.0
MongoDB version 6.0.0 is not recommended for production use in sharded clusters due to critical issue SERVER-68511 , fixed in later versions.
Read more >
6.0.0 – 2022-11-23 - Flake8
You can view the 6.0.0 milestone on GitHub for more details. Backwards Incompatible Changes¶. Remove --diff option (See also ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found