Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Deprecate `isOpen`

See original GitHub issue

I find this more convenient compared to the current approach.

{ condition ? (
<Modal
  onRequestClose={fn}
  closeTimeoutMS={n}
>
  <h1>Modal Content</h1>
  <p>Etc.</p>
</Modal>
) : null }

However, I haven’t tried this (whether is works), and I do not acknowledge any pros and cons of the approach besides a cleaner API.

Issue Analytics

State:
Created 8 years ago
Comments:8

Top GitHub Comments

2reactions

yvelecommented, Mar 7, 2017

@pstoica @srph @monsieurnebo @diasbruno So basically the whole point of isOpen is to allow animations through ReactTransitionGroup ?

If I don’t have animation, can you confirm that no using isOpen and returning null (no render atl all) is straightforward and well… better.

What the point of the portal? Only animation or is there some a11y magic?

1reaction

yvelecommented, Jul 27, 2017

@monsieurnebo CC

Top Results From Across the Web

DEPRECATE Pragma - Database - Oracle Help Center

The DEPRECATE pragma marks a PL/SQL element as deprecated. The compiler issues warnings for uses of pragma DEPRECATE or of deprecated elements.

MQManagedObject - IBM

The set of open options used when opening this resource. Setting this attribute has no effect. isOpen. public boolean isOpen. Deprecated. Accessing this...

Place Field Migration (open_now, utc_offset)

The Places fields opening_hours.open_now and utc_offset are deprecated as of November 20, 2019, and will be turned off on February 20, 2021.

ISOpen V4.4.1 by KoyoteSoft - Should I Remove It?

You can uninstall ISOpen from your computer by using the Add/Remove Program feature in the Window's Control Panel. On the Start menu (for...

BaseRedisAsyncCommands (Lettuce 6.2.2.RELEASE API)

Deprecated. since 6.2. Use the corresponding StatefulConnection.isOpen() method on the connection interface. To be removed with Lettuce 7.0.