Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add ability to disable fade on <Alert />

See original GitHub issue

I see this PR was merged to allow <Modal fade={false} />, but I’m wondering if the fade={false} prop could also be used on the <Alert /> component.

Issue description

components: <Alert />, <Fade />
reactstrap version 5.0.0-beta
import method umd (I don’t think I’m using “full”)
react version 16.2.0
bootstrap version 4.0.0

What is happening?

Attempting to use fade={false} on <Alert />, much like you can use it on the modal: <Modal fade={false />.

What should be happening?

When using <Alert fade={false} /> there should be no transition.

Issue Analytics

State:
Created 6 years ago
Reactions:5
Comments:10 (5 by maintainers)

Top GitHub Comments

3reactions

gergely-nagycommented, Feb 20, 2018

@TheSharpieOne I’d like to jump in on this! 🚀

3reactions

TheSharpieOnecommented, Feb 9, 2018

I like this idea and I would even take it a step further. Maybe instead of toggling a single transition, we can have the ability to pick the animation and/or disable it. The prop can be animation (or transition, but we already have transition…) animation="fade", (or animation={Fade} if we determine to just pass in the transition component) animation="collapse", or animation={false}. We can still default to Fade but this allows the transition to be disabled as well as changed.