question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Creating 1.x branch.

As we’re going to migrate recharts to TypeScript, it’ll be hard for us to maintain 2 versions at the same time. So, I guess we need to feature freeze 1.x version now and change them only when there is a severe bug like crashes or security problem.

  • Create 1.x branch from 1.8.3 commit. When something happens on 1.x, we go back to this branch and fix them and release newer 1.x version.

2.0 Goals

In 2.0, we’ll migrate ‘src/’ codes to TypeScript and support React 16.

Preparation -> #1911

  • Add UNSAFE_ prefix back. I explained why we need them on #1905.
  • Setup TypeScript with webpack.

Main Migration.

Things to do:

  • Get rid of propTypes. If we want to use propTypes, we might need to use this plugin.
  • Define types.
  • As for 2.0.0, our goal is to define types, not refactoring.

Phase 1 -> #1918

  • shape
  • container
  • components.

Phase 2

Phase 3

  • util -> #1921
  • charts
  • Remove as many anys as possible.

Release

  • Commit 2.0.0 and publish it.

2.1 and Later

  • Migrate Chai tests to Jest.
  • Introduce Storybook.
  • Maybe CI and eslint.
  • Refactor codes that don’t follow React convention (e.g. render() { return null; })

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:73
  • Comments:21 (9 by maintainers)

github_iconTop GitHub Comments

23reactions
kolesnikdianacommented, Jul 6, 2020

Hey, I used v1.8.5 but realized that there are no time scale support of Date type. I’ve found an example in Demo with the working solution and then updated my project to use v2.0.0-beta.6. But here is another problem now: as far as I use typescript I need to specify props types of custom rendered components. But there are no specific types exported. I’m wonder is it planed to support specific render type (like ContentRenderer) in v2.0 release?

Also I’d be happy to know:

  • Are there actually breaking changes in V2 or just a refactor to use typescript?
  • how stable the current v2 beta.6 version seems?
  • any idea on ETA date?

Thanks

20reactions
oneillsp96commented, Feb 24, 2020

Are there actually breaking changes in V2 or just a refactor to use typescript? Can anyone comment on how stable the current v2 beta version seems? Any idea when a stable V 2.x will be ready? Do you need help?

Read more comments on GitHub >

github_iconTop Results From Across the Web

X-Plan eligibility - FordPartner.com
Eligible employees (salaried, hourly and contract), retirees and household members may generate two (2) PINs per year to be used towards the purchase...
Read more >
CGI 3D Animated Short: "X-Plan 2" - by Xiong Hong Bing
Enjoy this CGI 3D Short Film about two funny guys,the story background for the second world war.​ Created by the talented Xiong Hong...
Read more >
What is the Ford X-Plan?
The Ford X Plan is a Discount Program that gives employees of Ford Partner ... Ford partner through a pay stub, company ID,...
Read more >
What Is the Ford X-Plan? | Demmer Ford in Wayne
For non-Ford Motor Company employees, X-Plan provides an opportunity to experience the benefits of driving a Ford Motor Company vehicle. Selected individuals ...
Read more >
Ford A-Plan, Z-Plan, X-Plan, D-Plan Pricing - CarsDirect
Ford X-Plan is actually two programs that equate to a discount for friends, family, and groups with special affiliations with Ford. First, Ford ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found