Extract YAML language service to another repo?
See original GitHub issueAs far as I know, yaml-language-server was invented to make a YAML plugin for code editors (especially vscode), and it is running as a standalone Node.js application in the extension.
To make it running inside of monaco-editor, the yaml language service has to be imported as a module dependency statically with UMD or ESM. What we are doing currently in monaco-yaml here is to copy /src/languageservice/*
into our repo as a native module which then could be statically imported, and finally to be built with tsc/vscode bundle helpers. This is clearly not a clean solution.
A better solution in my opinion is to extract the yaml language service into a new repo and publish it into vscode-yaml-language-service
. Then both vscode-yaml-languageserver(this repo) and monaco-yaml could depend on it.
What do you think?
Issue Analytics
- State:
- Created 5 years ago
- Comments:7 (6 by maintainers)
ok so the npm module must also contain the ts type definitions. I don’t know how everything is published to npm, but I guess that’s irrelevant, as long as the build script includes those definitions that should be ok. @pengx17 feel free to provide a PR
With https://github.com/redhat-developer/yaml-language-server/pull/305 this should be solved.