Connection leaking in 2.9.1 GenericObjectPool

Follow up of https://github.com/xetorthio/jedis/issues/1929 since the author closed the issue. I would really appreciate a backport like mentioned in the linked issue. Also, fyi, jedis 2.9.1 is the “official” version provided by Spring Boot 1.5.19.RELEASE as the dependencyManagement so this probably affects a lot of users. The 1.5.x branch is not in active development anymore but they are still supporting it through end of summer 2019 IIRC.

Expected behavior

No connection leak

Actual behavior

There’s a connection leak with heavy usage

Steps to reproduce:

With a heavy usage of jedis 2.9.1, the connections are slowly getting leaked and the pool starts rejecting connections after a while.

Redis / Jedis Configuration

Nothing special

Jedis version:

2.9.1

Redis version:

N/A

Java version:

java 8

Thanks!!

[eiselems]

Also, I’m thinking about all the users that will get jedis 2.9.1 with Spring boot that will spend a lot of time debugging this like I did, or even worse get problems in production

@jebeaudet I give you a “+1” for this 👍 Exactly what happened to us. But nice writeup here and in the other issues.

[snicoll]

@gkorland I understand that this issue was backported but I don’t see any 2.9.2 release on Maven central. @jebeaudet (thank you!) gave you enough information about our upgrade policy and I’ve declined your request to update as we would do it automatically.

We did, but no candidate release was available so we just released Spring Boot 2.1.3.RELEASE with this bug still present. Can you please let us know if a 2.9.2 release is scheduled? Thank you.