Jedis should use SLF4J instead of Java logging

Java Logging in not the industry standard anymore. User should be able to use the logging implementation he wants in order not to end up with several logging configuration files to maintain.

SLF4J provide a facade to the most commons logging formats: log4j, java logging and LogBack.

It also improve performances by having string build when needed Example: java logging

log.fine("Sentinel " + host + ":" + port + " published: " + message + ".");

will always build the string

slf4j

LOG.debug("Sentinel {}:{} published: {}.",host,port,message);

will build the string only if logging level is set to debug.

[HeartSaVioR]

@PatrickSauts Adding a dependency is what we try to avoid since Jedis claims itself as a lightweight library.

Jedis itself barely leaves log message, so I think you can just add jul-to-slf4j as your dependency and choose underlying logging framework to non jdk14. http://www.slf4j.org/legacy.html#jul-to-slf4j

Please give it a try and share the result. Thanks!

[marcosnils]

@PatrickSauts we try to keep Jedis as plain as possible regarding external dependencies. If you check the code you’ll realize that Jedis have almost no logging at all, and we decided that we’ll try to keep logging as minimal as possible as pretty much everything can be debugged from the redis logs / monitor commands.

If you check the code you’ll realize that there’s no logging at all, so unless we really have the need to support logging, I don’t think we’ll be addressing this soon.