returning Error from retry_strategy does not emit on(error) event

• Version: node 4.2.1 , redis 2.6.2
• Platform: Mac OS 10.11.5
• Description:

We had implemented a retry_strategy which emits an error after a certain amount of retries. This would then bubble to the on(‘error’) handler of Redis to be logged and exit the application. When updating our redis library from 2.4.2 to 2.6.2 we noticed that this behaviour is no longer the same.

Repro case:

const redis = require('redis');
const MAX_ATTEMPTS = 10;
var client = redis.createClient(port, host, { 
  retry_strategy: redisRetryStrategy
});
client.on('error', onError);

function OnError(err) {
  console.log(err);
  throw new Error('SHUTDOWN THE APP, REDIS IS NOT RESPONDING??');
}

function redisRetryStrategy(host, options) {
  if (options.attempt >= MAX_ATTEMPTS) {
    // Stop reconnecting after reaching the maximum number of attempts
    return new Error('Maximum redis reconnect attempts reached');
  }
  return 1000; // Schedule next reconnection attempt after 1 sec.
}

[BridgeAR]

Yes: Bubble up the error to the error listener

[AaronJan]

Bubble up ! (or something else)

Custom error emitter like @alannesta wrote is messy, retry_strategy is one of the constructor’s parameters, it shouldn’t accessing object that outside the function.

NodeRedis already had an event system, just use it!

Since end is been taken, and it means “connection is closed”, we can add a new event (let’s just call it “shutdown” for now) that indicating “we did everything we could, this connection is dead, from now on, we do nothing about it, you better do some clean up jobs”.

I really need this change.