RRateLimiter drift

Rate limit decreases over the time in highly concurrent environment. Demo of such drift is on screenshot. Rate there has been limited by only RRateLimiter.

Expected behavior Limit should not change without explicit call of setRate() with new value.

Actual behavior Limit changes over hours. As a workaround I explicitly call setRate() with the same values time to time.

Steps to reproduce or test case Just regular usage, nothing special:

    final long limitPerSecond = 115;
    final RRateLimiter limiter = redisson.getRateLimiter(name);
    limiter.setRate(RateType.OVERALL, limitPerSecond, 1000, RateIntervalUnit.MILLISECONDS);
    // ...
    limiter.acquire();

Redis version 6.0.5

Redisson version 3.16.1

Redisson configuration

    final Config config = new Config();
    config.useSingleServer().setAddress(url);

[mrniko]

Fixed! Thanks for report

[alim-akbashev]

it’s more or less reproducible. Please check the snippet https://gist.github.com/alim-akbashev/316f56197f099f323ff68cd27b51df78 It’s more simple to reproduce dritft when numbers in config are big, like 30k requests per 30 seconds, but issue appears with lower values as well, it just require more time to drift.

just in case, my config i’ve used to run that snippet: just regular macbook pro (Intel), Redis 6.2.5 in docker, openjdk 16

p.s. while i’ve been typing this comment, limit has dropped down to 29494, so it takes minutes, not hours with such config