Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
shouldComponentUpdate doesn't respect `null` -> `false` change
See original GitHub issuefalse is a valid field value. If you initialize your form field to null, then updating to false doesn’t re-render the form, even though the value did change.
The problem seems to be in
shouldComponentUpdate: https://github.com/erikras/redux-form/blob/master/src/reduxForm.js#L251
it is using deepEqual (https://github.com/erikras/redux-form/blob/master/src/structure/plain/deepEqual.js#L5) to
check if the value had changed.
I’m curious why this decision was made, and if it should be updated to recognize changes from null to false (and vice-versa), or at least document somewhere that the initial value needs to be undefined or you will get unexpected behavior.
Thanks!
Issue Analytics
- State:
- Created 7 years ago
- Reactions:13
- Comments:8 (2 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
+1, this is sometimes relevant for checkboxes + radio buttons.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.