[bug: typescript] ActionCreator lose it's arguments type

What is the current behavior?

https://github.com/reduxjs/redux/blob/beb1fc29ca6ebe45226caa3a064476072cd9ed26/test/typescript/actionCreators.ts#L13-L18

We declare the addTodo function that accepts one string argument text, but we could pass any argument to it.

const addTodoAction: AddTodoAction = addTodo(false, 0, null); 👆👆👆 //no ts error!

There may be a problem (...args: any[]) https://github.com/reduxjs/redux/blob/c676a25525bd7e4f2bf407cf1a135f355a2c1d79/index.d.ts#L440-L442

What is the expected behavior?

Raise a type error

[antmelnyk]

A very sad issue, in fact, a frustrating one.

The easiest way to fix this: just do not type the action creator itself and do not use this particular Redux typing, but instead type function’s returning value directly with your Action type.

So instead:

export const doSomething: ActionCreator<AppAction> = (value: number) => {
    return {
        type: TYPE.DO_SOMETHING,
        value
    };
};

Do this:

export const doSomething = (value: number): AppAction => {
    return {
        type: TYPE.DO_SOMETHING,
        value
    };
};

For redux-thunk the same approach, but it may differ based on how you actually type thunks in your app.

In my case it was instead this:

export const doSomething: ThunkActionCreator = (value: number) => {
    return dispatch => {
        dispatch(anotherActionCreator());
    };
};

Do this:

export const doSomething = (value: number): ThunkActionType => {
    return dispatch => {
        dispatch(anotherActionCreator());
    };
};

Where ThunkActionType is this:

(dispatch: ThunkDispatch<AppState, any, AppAction>, getState?: () => AppState) => void

[markerikson]

@chaabaj, @pixelgoo : we specifically recommend using our official Redux Toolkit package, which A) is already written in TS, and B) will auto-generate action creators for you:

https://redux-toolkit.js.org