question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Docs Rewrite] Meta-Issue: Rewrite Examples

See original GitHub issue

This is a tracking issue to cover all tasks related to rewriting our existing example projects.

Tasks

  • Decide which examples can be removed (like todos vs todomvc vs todos-flow)
  • Rewrite remaining examples with Redux Toolkit and React-Redux hooks

Issue Analytics

  • State:open
  • Created 3 years ago
  • Reactions:2
  • Comments:19 (14 by maintainers)

github_iconTop GitHub Comments

2reactions
markeriksoncommented, Oct 25, 2020

@giacomocerquone I think it’s worth reviewing all the examples, deciding what the original intended purpose was, and then deciding what the overlap is and what should be removed.

I do actually think the tree-view example is useful - this was a big question early on in the life of Redux about “do I just connect the top component, or multiple components?”, and it shows components extracting items from the store based on ID as well as recursive rendering. Someone over in Reactiflux was actually trying to port that to hooks as a learning exercise yesterday, which is what prompted me to file this issue.

todomvc is a slightly larger version of todos. This was more relevant when the TodoMVC project was being widely used as a comparison between varying UI frameworks, and it at least looks nicer than the barebones todos project, but tbh it can probably be removed.

Haven’t looked at async lately, but yes, it can probably be removed.

I would honestly just go replace counter with the contents of our Redux+JS template for Create-React-App:

https://github.com/reduxjs/cra-template-redux

Flow is dead, effectively. I would delete that one.

On the other hand, I would consider having a counter-ts example that copy-pastes the Redux+TS template for CRA. We ought to at have least one TS-based example in there somewhere.

The other thing to consider is that I’ve built out a larger real-world-ish app as the example for the “Essentials” tutorial, here:

https://github.com/reduxjs/redux-essentials-example-app

and this TodoMVC-based app for the “Fundamentals” tutorial:

https://github.com/reduxjs/redux-fundamentals-example-app

We’re going to keep those repos because I want them to be independently cloneable so people can try out the projects themselves, but we should probably either link to them on the “Examples” docs page, or copy-paste the final versions of the code into projects in the /examples folder.

@zpwebbear : No particular timeline for this. It’s just something that crossed my mind yesterday as a thing that needs to be done at some point.

1reaction
timdorrcommented, Oct 25, 2020

This is made redundant by #3565. I would still like to move the examples out of this repo, as they add a ton of weight to the test process and a lot of noise to the git history.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Creating Rewrite Rules for the URL Rewrite Module
This walkthrough will guide you through how to create and test a set of rewrite rules for the URL Rewrite Module.
Read more >
RewriteRule Flags - Apache HTTP Server Version 2.4
This document discusses the flags which are available to the RewriteRule directive, providing detailed explanations and examples. Support Apache! Introduction ...
Read more >
Set up URL rewrite for a global external HTTP(S) load ...
This example demonstrates rewriting the path specified in a request for a global external HTTP(S) load balancer (classic). To configure traffic management for ......
Read more >
Using meta refresh to create an instant client-side redirect
The page containing the redirect code should only contain information related to the redirect. Examples. Example 1. Example Code: <html xmlns="http://www.w3.org ...
Read more >
iis-docs/using-the-url-rewrite-module.md at main
In those cases, instead of defining a large set of simple rewrite rules, you can put all the mappings between into the rewrite...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found