Using entity adapters inside reducers in 1.5.0

Hi, would be thankful for a little help here. From the changelog of 1.5.0 I understood that we who use our entity adapters inside reducers are covered by:

We’ve also updated createEntityAdapter’s getSelectors API to use these draft-safe selectors.

So lets define an adapter:

const tabsAdapter = createEntityAdapter<Tab>();
export const tabsSelectors = tabsAdapter.getSelectors<State>((state) => state.tabs);
export const { selectById: selectTabById } = tabsSelectors;

Then use it in some reducer:

    setSomething(state, action: PayloadAction<{ tabId: string; foo: string }>) {
      const { tabId, foo } = action.payload;
      const tab = selectTabById(state, tabId);
      if (tab) {
        tab.foo = foo;
      }
    },

Works in 1.4.0, but fails in 1.5.0 during runtime with:

TypeError: Cannot assign to read only property 'foo' of object '#<Object>'

or this one if the property was not yet set

TypeError: Cannot add property foo, object is not extensible

Could someone please explain what is the migration path here from 1.4.0 -> 1.5.0?

[smajl]

@markerikson Correct, not calling getSelectors() everytime, that was just an example, in reality we are using stored and correctly typed selector variants (because our entity adapter has an union type). Thanks for the reply, will get rid of the these selectors inside reducers and hopefully finally fully migrate to 1.5.0. 😄

[smajl]

@phryneas I see, so I handled updates the unsafe way from the very beginning. 😇 Thanks a lot for the clarification and super fast response! The update*/upsert* methods are what I needed!