Capitalization inconsistency with `yarn rw g page` generator

Reproducible by doing: yarn rw g page ABTest

Which will add the following line to Routes.tsx

<Route path="/ab-test" page={ABTestPage} name="abTest" />

But will generate directory pages/AbTestPage with AbTestPage.tsx , stories, jest files with the b uncapitalized

[cannikin]

So obviously creating files and routes manually you can use any capitalization you want and you’re good to go.

The problem is the generators because we want to follow component naming convention and make them PascalCasePage. We can’t just accept the user’s casing because we could end up with fooPage or anything else. That means running it through the pascalcase package, and in this case it looks like it actually has the behavior we want, because:

pascalcase("ABTest") # => "ABTest"

It looks like the problem is in the code that converts the string entered on the command line to the filename. It actually does two conversions:

pascalcase(paramCase("ABTest")) # => "AbTest"

The param-case package turns everything lowercase first, then turns any special characters into dashes.

I’m sure there’s a reason we did this, and it was probably to make sure that if you did something like yarn rw g page FOO_BAR you wouldn’t end up with FOOBARPage (which is what would happen without that extra paramCase). The list of test cases checks that all of these inputs all become FooBarPage:

• FooBar
• fooBar
• foo-bar
• foo_bar
• FOO_BAR

I double checked Rails behavior (of course) and using the generators actually removes multiple capitals in a row to end up with true PascalCase: ABtest => AbTestController.

I’m okay with keeping the user’s intended capitalization (after running through pascalcase). The number of people generating with an all-caps name is probably pretty low, and if they do want that, who are we to stop them? So, that means we would leave the route generation as-is and remove the extra paramCase call in the filename generation. Everyone okay with that?

[aggmoulik]

Well, I am with the community I just want to share my views. I will update the PR.