improve generated Service test template

@RobertBroersma @peterp

The current generated Service test is not actually testing the generated Service code (i.e. not even if it exists):

// api/src/services/posts/posts.test.js

/*
import { posts } from './posts'
*/

describe('posts', () => {
  it('returns true', () => {
    expect(true).toBe(true)
  })
})

Given the recent MSW integration with test DB, could we update this to at least be meaningful?

And we do have two cases to consider if we’d like to handle both distinctly:

1. yarn rw g service post (no CRUD)

// api/src/services/posts/posts.js

import { db } from 'src/lib/db'

export const posts = () => {
  return db.post.findMany()
}

1. yarn rw g service post --crud

// api/src/services/posts/posts.js

import { db } from 'src/lib/db'

export const posts = () => {
  return db.post.findMany()
}

export const post = ({ id }) => {
  return db.post.findOne({
    where: { id },
  })
}

export const createPost = ({ input }) => {
  return db.post.create({
    data: input,
  })
}

export const updatePost = ({ id, input }) => {
  return db.post.update({
    data: input,
    where: { id },
  })
}

export const deletePost = ({ id }) => {
  return db.post.delete({
    where: { id },
  })
}

[cannikin]

Worked on some stuff with @mojombo this afternoon and I’m recording this here for posterity… another possible way to define fixtures. Uses the target model as the root key in the object (comment) and then gives each fixture a name with the second level key:

export const FIXTURES = {
  comment: {
    rob: {
      name: 'Rob',
      body: 'This is my comment',
      post: {
        create: {
          title: 'First Post',
          body: 'Lorem ipsum',
        },
      },
    },
    tom: {
      name: 'Tom',
      body: 'Also a great comment',
      post: {
        create: {
          title: 'Second Post',
          body: 'Dolar sit amet',
        },
      },
    },
  },
}

This would allow us to:

1. automate creating the fixtures because we can derive the model name from the object
2. reference the fixtures by name in the tests

it('retrieves comments', async () => {
  const data = await comments()
  expect(data[0].name).toEqual(FIXTURES.comment.rob.name)
})

Maybe rather than referencing the FIXTURES directly we can create a fixtures function which will reference the fixture data after being added to the database so that we can access any fields that were created by defaults in the database:

it('retrieve a single comment`, async () => {
  const data = await comment({ id: fixtures().comment.rob.id })
  // id is not present the fixture but `fixtures()` returns the result of the record being added to the database
  expect(data.id).toEqual(fixtures().comment.rob.id)
  // same with createdAt, it's defaulted to "now" by prisma in the DB
  expect(data.createdAt).toEqual(fixtures().comment.rob.createdAt)
})

Oh snap, now we’re on to something…

[cannikin]

IT’S HAPPENING https://github.com/redwoodjs/redwood/pull/1465