Nav: Replace the static class of constants with an actual configuration file
See original GitHub issueIs the improvement related to a problem? Please describe.
Yeah, the problem is that, each time a user updates their nav package, the constants will be replaced. Users may well change these values, and then have them unknowingly replaced, which could cause hard-to-track-down bugs.
Describe the solution you’d prefer:
To override navigation settings at the user-level, there ought to be a configurable NavWorld
and/or blob asset with reasonable defaults. This change will probably confuse preexisting users when they upgrade, but it’s for the best.
Describe alternatives or workarounds you’ve considered:
I don’t think the constants file has ever really been a good idea, honestly. I went with it at the beginning of this year because DOTS’ lack of maturity (at the time) precluded the suggested solutions above.
Issue Analytics
- State:
- Created 3 years ago
- Comments:14 (9 by maintainers)
Top GitHub Comments
The refactor is nearly done. It’s required some deviations from what was discussed above, but I think most people will be happy with the result. Only issue is that I’m noticing some agents getting stuck in the
NavTerrainDemo
. I need to do some testing to see what’s happening with that. It could be that a value got mixed around or something.After that, I’ll create an override system in the demo code, not in the
nav
package, so that people can just easily copy-paste it or change it if forking this repo. Following that, an update to the docs. I’ll do one big commit for it all.Thanks, and you’re welcome. I’ll let you know when this is done.