⚠️ Many features don't work until you refresh the page

Please ensure:

• The bug is caused by Refined GitHub. It doesn’t happen if I disable the extension.

Description

One of the recent AJAX PRs might have broken the loader altogether. One example I see is in the PR Files tab.

1. Open https://github.com/sindresorhus/refined-github/pull/4685
2. Click the files tab
3. Notice that almost every feature is missing:

• remove-diff-signs
• pr-jump-to-first-non-viewed-file
• faster-reviews
• collapsible-button (but table-input is working, these 2 should be identical)
• batch-mark-files-as-viewed
• etc etc etc

1. Refresh the page, everything works

cc @kidonng @dertieran @cheap-glitch @yakov116 as you’ve recently worked on the ajax part

Screenshot

Console errors

No response

Example URL

https://github.com/sindresorhus/refined-github/pull/4685 -> then click the files tab

Browser(s) used

Safari

[williammck]

Dug around for a bit, this is due to deduplicate not being set to has-rgh-inner on some features after https://github.com/sindresorhus/refined-github/pull/4571.

e.g. if I apply the following patch, faster-reviews now starts functioning properly even after multiple tab clicks.

diff --git a/source/features/faster-reviews.tsx b/source/features/faster-reviews.tsx
index 1b11bd54..7cc4e23c 100644
--- a/source/features/faster-reviews.tsx
+++ b/source/features/faster-reviews.tsx
@@ -54,6 +54,7 @@ void features.add(__filebasename, {
                },
        ],
        awaitDomReady: false,
+       deduplicate: 'has-rgh-inner',
        init: addSidebarReviewButton,
 }, {
        shortcuts: {
@@ -63,5 +64,6 @@ void features.add(__filebasename, {
                pageDetect.isPRFiles,
        ],
        awaitDomReady: false,
+       deduplicate: 'has-rgh-inner',
        init: initReviewButtonEnhancements,
 });

I may spend some time this weekend identifying where all this needs to be updated, if no one gets to it before then.

[fregante]

This has been fixed for many PR-related features and will be in the upcoming v21.10.1.

If you still see this problem after updating, please leave a link to the page you’re seeing the issue on (i.e. the page you have to refresh for features to appear)