question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add buttons to `clear-pr-merge-commit-message` and related features

See original GitHub issue

Description

Instead of automatically clearing the field, I wonder if we could add some buttons in the mergeability box to:

This issue replaces:

Avoiding automatic replacement would also avoid:

Related:

Screenshot

Screen Shot

Example URL

https://github.com/refined-github/refined-github/pull/3

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:14
  • Comments:12 (7 by maintainers)

github_iconTop GitHub Comments

8reactions
JelteFcommented, Dec 3, 2022

We need to decide what to do with our current features regarding PR titles, if we can detect a custom setting and avoid overriding it.

Since one of the settings that github provides is exactly what is being done by refined github now, I don’t think there’s a reason to keep these settings. In the current state it gives you less configurability than Github does. I think the clear-pr-commit-title setting should at least be disabled by default, because it now messes up the repo settings.

3reactions
fregantecommented, Dec 3, 2022

GitHub added some controls over this, which are likely to stay “per-repo”:

https://github.blog/changelog/2022-08-23-new-options-for-controlling-the-default-commit-message-when-merging-a-pull-request/

We need to decide what to do with our current features regarding PR titles, if we can detect a custom setting and avoid overriding it.

Edit: we can’t detect it, but we added a notice so the user knows what’s happening and can disable the feature.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to Add Buttons and Text Fields in XCode 12 | Swift
When developing iOS Apps and coding with Swift in Xcode, your user interface design needs textfields and buttons for forms.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found