backtick insertion within current selected text, includes trailling whitespaces

backtick insertion of a current selected text, includes trailling whitespaces, which it shouldn’t

repro

• while editing/creating a issue double click a word
• the double-clicked word get selected (including the trailling whitespace behind the word)
• press the backtick-key and refined github will sorround the selected word with backticks (including trailing whitespace)

example:

• a issue contains the text “the lazy fox jumps over…”
• double click the word ‘lazy’
• press the backtick-key
• the resulting markup is “the lazy fox jumps over…” while it should be “the lazy fox jumps over…” (spot the positions of the backticks)

reproduced in firefox 90a1 on windows10x64, with refined github 21.5.19. also reproducible on chrome 93.0.4525.0 on the same machine

[fregante]

maybe its even a windows problem

Selecting the trailing whitespace appears to be a Windows behavior; Wrapping the exact selection is universal: Not a Refined GitHub problem, not GitHub’s, not Chrome’s, not Windows’.

your recording looks like I would expect it.

I think you’re referring to the word selection, because that’s the only different part — and Refined GitHub can’t change that.

[fregante]

You were onto something here! There’s an exception: \n

This feature however is handled by https://github.com/fregante/text-field-edit so any changes should be pushed to that repo. It’s a little tricky because this changes the selection as well.