question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`bug #1234` sometimes creates a link, sometimes doesn't

See original GitHub issue

in https://github.com/nim-lang/Nim/pull/14796/files bug #1235 (or issue #1235) does not create a link to the corresponding github issue;

image

in other cases it does: https://github.com/nim-lang/Nim/pull/14795/files

image

How do we make it always work?

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

2reactions
notlmncommented, Jun 26, 2020

This is because of https://github.com/sindresorhus/refined-github/blob/master/source/features/linkify-code.tsx#L26-L28, only issue references that are inside “code comments” are linkified.

In this case, GitHub doesn’t highlight rst diffs enough for us to tell if it is a comment we have to process or part of code that should be ignored.

@fregante, maybe we should also linkify issue references that are outside of comments. Is something stopping us from doing that?

1reaction
notlmncommented, Jun 26, 2020

that’s the whole reason I’d want to use this

This feature is to linkify issue references inside code comments, where we can say if a particular part of code is a comment.

In this particular case where you have a nim code block inside an rst file, GitHub doesn’t process that code block. This seems to also happen in md files too (example).

By your own example it does work inside regular nim file diffs, as you expect it to.

Read more comments on GitHub >

github_iconTop Results From Across the Web

`bug #1234` sometimes creates a link, sometimes doesn't · Issue ...
in https://github.com/nim-lang/Nim/pull/14796/files bug #1235 (or issue #1235) does not create a link to the corresponding github issue; in other cases it ...
Read more >
3 Common URL Problems and How to Fix Them - SEO.com
Problem #2: Duplicate Home Page URLs​​ It is possible to have a lot of different URLs that all go to your home page...
Read more >
1771 - sendKeys() sometimes doesn't enter all the characters ...
It looks like not all characters entered in input field. So tests end up with such an error: "java.lang.AssertionError: The following asserts ...
Read more >
How to Find and Fix Broken Links (to Reclaim Valuable "Link ...
Redirect (301) the broken page to the new location: Sometimes you may change the URL of a page and forget to redirect. This...
Read more >
Internet Tips: Tips for Fixing Broken Links - GCF Global
This is caused by a broken link. There are a couple of reasons a link may be broken: The page no longer exists....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found