question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Bug on pull request files tab

See original GitHub issue

RGH Version: 19.6.30 (Chrome)

GitHub recently added a new feature for marking files as viewed when reviewing a pull request. The following bugs happen when Refined GitHub is enabled. Confirmed by disabling all browser extensions but RGH.

  1. When the length of the PR title + number is too long, it wraps the right-floated elements to a new line.
  2. When the filename of the file currently in view is too long, the scrolling “file actions” bar is malformed (for lack of a better term). Edit: It’s possible that it only happens if the first filename is too long, as on the example PR below, the second filename is even longer, yet it looks just fine.

Edit 2: When I disable faster-pr-diff-options it fixes both bugs.

This is an example PR: https://github.com/pymedusa/Medusa/pull/6893/files


RGH disabled

chrome_XwwqDu9Y0Q


RGH enabled

chrome_ePXSiihJ2e

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:9
  • Comments:17 (14 by maintainers)

github_iconTop GitHub Comments

3reactions
sindresorhuscommented, Jul 11, 2019

My suggestion would still be to keep #1799, change the whitespace button text to ␣ and limit the length of the title.

Let’s do that. But the button should have a tooltip as is not clear enough.

3reactions
jeronecommented, Jul 9, 2019

My suggestion would still be to keep #1799, change the whitespace button text to and limit the length of the title.

a.js-issue-title.css-truncate.css-truncate-target.link-gray-dark {
-	max-width: 35em;
+	max-width: 30em;
}

Title max length can be shortened further because it’s not important information in this context. You already know what you are reviewing. I rather keep those most used buttons while reviewing.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Bug on pull request files tab · Issue #2202 - GitHub
When the filename of the file currently in view is too long, the scrolling "file actions" bar is malformed (for lack of a...
Read more >
Azure devops pull request files tab - Visual Studio Feedback
when I click on pull request link and then click on files tab I received the following error. An unexpected error occur with...
Read more >
GitHub Pull Requests: infinite loading on Files and Commits ...
GitHub Pull Requests: infinite loading on Files and Commits tabs of New Pull Request tab in some cases ; Priority, Normal N ;...
Read more >
Pull request Files tab scroll bar | Bitbucket Cloud - Jira Atlassian
Currently, if you have lots of files in a pull request, you'll have to navigate to the Files tab to view those files....
Read more >
Azure DevOps Resolve Pull Request Conflict - Stack Overflow
Show activity on this post. So, I have a very strange issue with Azure. In pull request, it is detecting some conflicts, but...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found