Button links in global Pull requests / Issues pages are messed up

Links to reproduce: Pull requests, Issues. Then click either the Commented or Yours button.

You can see in the screenshot that the href attributes of the original buttons (Created, Assigned, Mentioned and Review requests in the Pull requests page) don’t have a space (+) after the archived:false attribute.

This is what it loads if I press one of them:

And this is how it looks with the extension disabled:

I have version 19.4.7.1857 of the extension.

Great work on the project. Keep it up! 😃

[mcornella]

That’s how it was at some point but that also matches user:bfred in user:bfred-it when used after. The space is the right separator to use, but it shouldn’t also be dropped from both sides.

This is also happening with the current code given that the separators around the query are optional in the regex, given that it’s using ?. I’ve put together a PR that fixes this as well: #1926.

I finally wound up using split + filter + join to remove the query parameter, and it seems to be working well. Thanks for the guidance!

[fregante]

That’s how it was at some point but that also matches user:bfred in user:bfred-it when used after. The space is the right separator to use, but it shouldn’t also be dropped from both sides.