question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Change button colour background to the `Draft` PR label

See original GitHub issue

It’s nice to have “labels” on our pull requests, though with a Draft pull request this isn’t always practical, though when you view a list of PRs the Draft PR label/status is easily missed, adding a light grey background colour to the Draft text would help make these stand out a little clearer IMHO.

Example URL: https://github.com/WordPress/gutenberg/pulls Screen Shot 2019-09-20 at 12 47 58 pm

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:2
  • Comments:13 (9 by maintainers)

github_iconTop GitHub Comments

2reactions
fregantecommented, Dec 2, 2019

I name this feature emphasize-draft-pr-label , aimed at making that label stand out

I don’t think draft PRs should stand out, but the opposite, like you said next:

the color ‘gray’ itself says “Oh oh don’t pay too much attention to me”

The gray does that, but the size doesn’t; the visual weight is higher.

I’d go as far as dimming the whole line instead.

Regular

gray icon

Now

gray background

Suggested

Opacity 0.7

dimmed line
2reactions
fregantecommented, Sep 20, 2019
Screenshot 2019-09-20 at 10 31 05

Like this?

/* demo */
span[aria-label="Open draft pull request"] {
    background: #e8e8e8;
    width: 1.6em;
    display: inline-flex;
    height: 1.6em;
    align-items: center;
    justify-content: center;
    border-radius: 50%;
    margin: -1em;
    margin-left: -0.4em;
    margin-right: -0.2em;
}
span[aria-label="Open draft pull request"] svg {
	color: white !important;
}
Read more comments on GitHub >

github_iconTop Results From Across the Web

Change button colour background to the Draft PR label #2450
I name this feature emphasize-draft-pr-label , aimed at making that label stand out. Felt that level of gray - IMHO the color 'gray'...
Read more >
python - How to change the foreground or background colour ...
There is a solution for changing the background of buttons on Mac. ... Then have the label change colors for a short time...
Read more >
How to Change the Button Color in HTML - wikiHow
1. Type and tags. The body is where the visible elements of a web page are placed using HTML. 2. Type style= after...
Read more >
Change Submit Button Style and Color | Adobe Marketo Engage
Change Submit Button Style and Color · Go to Marketing Activities. · Select your form and click Edit Form. · Select the Submit...
Read more >
How do I change the revision set colors? - Final Draft
To change the names and colors of Final Draft's revision sets, go to Production > Revisions Setup > Revision Settings (Windows) or Production...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found