question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`conflict-marker` icon doesn't align with check icon

See original GitHub issue

Please ensure:

  • The bug is caused by Refined GitHub. It doesn’t happen if I disable the extension.

Include in this issue:

  • Screenshots/video/gif demonstrating the bug, if it’s visual
  • Console errors, if any

Description

image

The success CI icon after conflict-marker is too low (compared to the failure icon), though that’s GitHub’s fault. We already have a case of adjusting the align of the icon in ci-link, maybe we can do it for conflict-marker too.

Example URL

https://github.com/npm/cli/pulls

Browser(s) used

Chrome

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:1
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
fregantecommented, Oct 28, 2021

I think this is a visual illusion

Definitely part of the issue, but they are slightly misaligned.

It seems to me both icons have the exact same alignment:

You’re highlighting their parents, not the SVGs:

Screen Shot

I think we just need to move the conflict marker lower if possible — ideally without using px values in vertical-align. Maybe we have to choose between baseline and middle

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to align the icon of a marker in google map
Imagine my marker icon is a circle, I would like the center of it to be at the lat-lng of the given point......
Read more >
Material Icons - Vertical Align Doesn't work well alongside ...
Hi, Material icons doesn't seems to vertical align themselves when placed alongside any text. Issue: I am using this code: Open 7 Days ......
Read more >
BC4 doesn't always show all conflicts in file - Scooter Forums
It might help to make sure View > Ignore Same Changes and View > Ignore Unimportant Differences are both turned off. Selecting an...
Read more >
Add something into L.CircleMarker
Simple solution to this is to create your own group marker, which is combination of L.circleMarker and L.marker with L.divIcon icon.
Read more >
Poll: how do you jump to Git conflict markers? : r/neovim
When you merge/rebase/unstash in Git, conflicts may happen. ... consider ^<<< only as an example for a conflict marker search pattern.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found