`default-branch-button` does not work with long branch names that are truncated in the UI

Please ensure:

• The bug is caused by Refined GitHub. It doesn’t happen if I disable the extension.

Include in this issue:

• Screenshots/video/gif demonstrating the bug, if it’s visual
• Console errors, if any

Description

The Problem

Press the default-branch-button in the example url, and it will redirect you to https://github.com/gamemaker1/express-rate-limit/commits/opiniated-impr.... This is because the branch name is truncated in the #branch-select-menu div.

Possible Fix

Change the selector in the getDefaultBranch helper function that retrieves the branch name from the UI:

https://github.com/refined-github/refined-github/blob/main/source/github-helpers/get-default-branch.ts#L26

From:

select('#branch-select-menu [data-menu-button]');

To:

select('#branch-select-menu [data-menu-button]:not(.css-truncate-target)');

So that it makes an API call and gets the default branch instead of using the truncated name from the UI (an alternative would be getting the branch from somewhere else in the DOM).

Not tested, but I think this should work.

Example URL

https://github.com/gamemaker1/test/tree/very-very-long-long-long-long-branch-name

Browser(s) used

Firefox

[kidonng]

I think this is already fixed in the associated PR.

[fregante]

That’s why it happened. We have a few ways to figure out the default branch and one of them might be reading the truncated value somewhere.

To fix this, we just need to verify all of these ways