question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Distinct referenced commits style

See original GitHub issue

Before

before

Before (with explanation of the problem)

Confusing, looks like the pull request commits and the commit that references this pull request are in the same branch.

before-explanation

After

after

Style

.discussion-item-header[id^=ref-] .discussion-item-icon {
  background-color: #6db2ff;
  color: #ffffff;
}

.discussion-item-header[id^=ref-]::before {
  content: '';
  position: absolute;
  display: block;
  z-index: -1;
  left: -25px;
  top: -40px;
  width: 2px;
  height: 140px;
  background-color: #ffffff;
}

.discussion-item-header[id^=ref-commit-] + .discussion-item-body .timeline-commits .commit .commit-icon {
  color: #6db2ff;
}

.discussion-item-header {
  position: relative;
}

.discussion-item-header[id^=ref-commit-]::after {
  content: '';
  position: absolute;
  display: block;
  z-index: 0;
  left: -25px;
  top: 30px;
  bottom: -20px;
  width: 2px;
  background-color: #6db2ff;
}

.discussion-item-header[id^=ref-commit-] + .discussion-item-body .timeline-commits {
  position: relative;
}

https://gist.github.com/sompylasar/99b5d307da3168b833c1119fb95caf11

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:1
  • Comments:8 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
fregantecommented, Jun 23, 2019

This is really annoying. I sent another request at https://github.com/contact

Commit references in PR are very confusing

Open this: https://github.com/sindresorhus/refined-github/pull/2167#ref-commit-7d6e4d1

Can you tell which commits are part of the current PR and which aren’t?

Answer: only the merge commit is, but there’s no way to tell.

Please display commits with PR references differently in PRs.

More context: https://github.com/sindresorhus/refined-github/issues/1579

1reaction
sindresorhuscommented, Feb 15, 2019

@busches I would say just plain CSS. The change is uncontroversial and I don’t see why anyone would genuinely need to disable it.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Distinct referenced commits style · Issue #1579 - GitHub
Confusing, looks like the pull request commits and the commit that references this pull request are in the same branch. before-explanation ...
Read more >
Understanding Refs, branches and dangling commit in Git?
Refs or references are the pointers to commits. that's it. But let's look at it from the other side: Every git enabled project...
Read more >
Commits API - GitLab Docs
Get references a commit is pushed to. Get all references (from branches or tags) a commit is pushed to. The pagination parameters page...
Read more >
How does Git create unique commit hashes, mainly the first ...
Git uses the following information to generate the sha-1: The source tree of the commit (which unravels to all the subtrees and blobs) ......
Read more >
pretty-formats Documentation - Git
This format is used to refer to another commit in a commit message and is the same as --pretty='format:%C(auto)%h (%s, %ad)' . By...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found