question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Do not hide PR reviews verdict (hide-useless-comments)

See original GitHub issue

It seems the new hide-useless-comments feature is too gourmand as it also hides the PR review verdict completely when it has only a reaction comment.

capture d ecran 2018-09-20 a 18 18 12
capture d ecran 2018-09-20 a 18 18 20

Should the PR verdict still be visible by only hiding the comment below ?

Thanks !

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:8
  • Comments:19 (12 by maintainers)

github_iconTop GitHub Comments

1reaction
tandrewnicholscommented, Sep 21, 2018

I mean, you could ignore private repositories cause everyone is a collaborator. Right?

1reaction
tandrewnicholscommented, Sep 21, 2018

Oh, you mean like this:

screen shot 8

or this:

screen shot 9
Read more comments on GitHub >

github_iconTop Results From Across the Web

Do not hide PR reviews verdict (hide-useless-comments) #1543
Nice catch! Yes, PR reviews should definitely be excluded. The logic should have done that already (they are by team members and therefore...
Read more >
Do people think your PR comments sound arrogant or ... - Reddit
The one time a saw a team try to use this, people would critique other's comments and correct them for not using emojis...
Read more >
Hiding Comments on Facebook: The Definitive Guide (2022)
Want to hide comments on Facebook? This definitive guide discusses the when, why and how of hiding comments on Facebook.
Read more >
"I Have Nothing To Hide" And Other Stupid Statements - Medical ...
If you or a loved one were injured by the medical negligence of a medical provider, you should promptly seek the legal advice...
Read more >
Please don't "bury" PR comments just because the relevant ...
This is a neat feature in some ways, but it makes it nearly impossible to audit whether particular a comment has actually been...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found