Double-scroll areas after expanding all lines

Please ensure:

• The bug is caused by Refined GitHub. It doesn’t happen if I disable the extension.
• The bug happens after clearing extension cache. The “Clear cache” button below can also be found at the bottom of the options page.

Example URLs

https://github.com/refined-github/refined-github/pull/5422/commits/1bb5e36ce3734a045c5e4aaeeba6e0d29d381789#diff-84b7041bfeae43fea26aac38d2eb71d1c2ce5d7bdb2cd6a9a7b3502662a26da8

Extension version

22.3.3

Browser(s) used

Brave – Version 1.35.100 Chromium: 98.0.4758.87 (Official Build) (arm64)

Description

1. View 1bb5e36 (#5422)

2. Expand file source/features/collapsible-content-button.tsx

3. Scroll up and down

Expected: Only one scroll area for the webpage’s document’s body or window is present

Actual: There is another scroll area present for the file container element with a little amount of scroll leeway.

Screen Recording:

https://user-images.githubusercontent.com/517469/157112498-a2ec92ff-bc3c-4f2f-a6fc-bec678a3683c.mp4

Include in this issue:

• Screenshots/video/gif demonstrating the bug, if it’s visual
• Console errors, if any

[cheap-glitch]

I haven’t checked but I assume that that would change (break) the number text alignment

Actually, those are not the line numbers but the +/- diff signs, which are hidden by RGH anyway.

[fregante]

overflow-y: hidden

vade retro satana

As the name suggests, that just hides the issue.

I found the cause by deleting one element at a time in the table:

This is the line number and that top: 1px pushes it 1px outside the table, which lengthens the scrollable content. A fix could probably just add margin-bottom: -1px to it but I don’t remember if that actually reduces the scrollable height.