question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Enhance suggestions in PRs

See original GitHub issue

It would be cool to have automatic suggestion when reviewing a PR.

Currently if there is some code written:

console.log('Hello');
console.log('World');

And I would like to suggest that the person could write otherwise, I have to:

  1. Select the lines
  2. add ```suggestion <suggested_code> ```
  3. Usually rewrite 99% of the code (including matching spacing) into a comment, where 1% is the diff

That results in writing a comment:

```suggestion console.log('Hello', 'World'); ```

I think a button could appear when selecting the line(-s) on a PR that would say “Suggest change” and if clicked, would prefill the comment with ```suggestion <selected_code> ```

It could appear in https://github.com/<username>/<repo>/pull/<pull_id>/files

I would be more than happy to implement it myself

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:2
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
fregantecommented, Aug 20, 2020

Uhm, that button already exists, it’s the ± button. You never have to manually type ```suggestion

  1. Select lines
  2. Click the “Add suggestion” button

2a

0reactions
dvisockascommented, Aug 21, 2020

Uhm, that button already exists, it’s the ± button. You never have to manually type ```suggestion

  1. Select lines
  2. Click the “Add suggestion” button

2a

Great, thanks for the info.

Read more comments on GitHub >

github_iconTop Results From Across the Web

PRS Teaching Tips – CTE Resources
Use PRS Questions As A Tool For Peer Learning. You might ask a question and have students discuss their answers with each other...
Read more >
How to write and manage PRs that spark joy - Peter Lunch
A guide to writing and managing your PRs so good they spark joy in the reviewer. Learn from my experience and take the...
Read more >
Best PRS Upgrades! - YouTube
Do you have a PRS ? No matter what type we have upgrade parts for you! In this video, Justin goes over the...
Read more >
Recommendation strategy for the implemented PRS
The PRS that was developed for that experiment provides advice of the next best learning activity to follow based on the interest of...
Read more >
PRS SE 24 Standard Pickup Upgrade suggestions?
I'm looking for an affordable lower output pickup set/combination that will offer a more bright, clean and articulate tone but will still ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found