Escape key canceling comments is conflicting with closing the emoji menu
See original GitHub issueI’m talking about this code : https://github.com/sindresorhus/refined-github/blob/master/source/features/add-keyboard-shortcuts-to-comment-fields.js#L42-L50
The problem is that when you type a :
after a
, GitHub opens the emoji menus, and the most obvious way to close it is with the esc
key, but the esc
key will close the comment. In some cases (but not all), you get a confirmation window, so you actually don’t lose what you’ve typed. In some cases you don’t. This makes this feature actually really painful.
This problem happens a lot when you write comments using languages that require a
before :
, like French.
Issue Analytics
- State:
- Created 5 years ago
- Comments:16 (5 by maintainers)
Top Results From Across the Web
Cancel confirmation in "Files changed" tab not working #1310
levrik mentioned this issue on May 9, 2018. Escape key canceling comments is conflicting with closing the emoji menu #1252. Closed.
Read more >Mac keyboard shortcuts - Apple Support
Learn how to change a conflicting keyboard shortcut.) Control–Command–Space bar: Show the Character Viewer, from which you can choose emoji and ...
Read more >No longer can pres Esc key to close comment window...
Use the following steps: 1. In the Acrobat, go to Edit menu > Preferences > Commenting. 2. On the right-hand side of the...
Read more >Add an option to never show the smiley picker / Disable emoji
If you press Esc , then it doesn't close the emoji picker - it ... Suppress the fear that you're going to lose...
Read more >Keyboard shortcuts in Excel - Microsoft Support
Close a dialog box or cancel a process, such as a paste operation. Ctrl+Esc. Open the AutoFilter Menu dialog box. Alt+Down arrow key....
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
The problem is not not that you get or don’t get the confirmation modal, but that the esc key should close the emoji/people selector menu, not try to close the comment.
If I find a case where the confirmation screen is not asked, I’ll add info, but for me, the main part is that “esc” should just close the menu.
I just hit this issue. Wrote some internal review on a PR and lost everything because I tried to close this emoji view. Started to rewrite everything, almost finished it and again… this time I wanted to write an @ but this brought up the mentioning menu… and I automatically pressed escape and lost everything again. Sadly I’ve disabled the extension and won’t enable again until this is fixed. This issue costed me around 45 minutes today… and a lot of frustration.