Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Hide successful checks by default in PRs

See original GitHub issue

Description

Currently PRs look like this, which makes it difficult to see what failed exactly:

What if we hid the passing ones if any are failing?

Drawbacks

In this mode, you can’t see which tests actually succeeded
Modifying this active widget could be difficult, but maybe a smart use of element-observer could make it easy enough
This feature could be implemented in CSS only with :has, but then it would be difficult to “show all” (maybe via :not(:focus-within)?)

Similar requests

Example URLs

https://github.com/fregante/content-scripts-register-polyfill/pull/58

Issue Analytics

State:
Created a year ago
Reactions:2
Comments:7 (6 by maintainers)

Top GitHub Comments

3reactions

fregantecommented, Jul 27, 2022

That selector actually pushes successful checks to the bottom, so running checks and failed checks will still be at the top, interleaved. We can use this order:

failed (because you want to see and address them as soon as possible)
running (because more checks can fail soon)
successful/skipped

2reactions

fregantecommented, Jul 27, 2022

Here’s a CSS-only feature with :has():

/* Hide successful statuses only if any failed #5856 */
.merge-status-list:has(.octicon-x) .merge-status-item:has(.octicon-check) {
	display: none !important;
}

And here’s another version that probably solves every single problem at once (except “sort by name”)

/* Dim successful checks and bring failed checks to the top (unless everything is successful) #5856 */
.merge-status-list:has(.octicon-x) .merge-status-item:has(.octicon-check) {
	opacity: 0.5;
	order: 1
}

.merge-status-list:has(.octicon-x) {
	display: flex;
	flex-direction: column;
}

I don’t particularly care that this is “Safari-only” at the moment because Chrome will follow soon and Firefox will follow eventually. Feels like a good win for 8 lines of inert code 😃