`linkify-code` links to incorrect url in search pages
See original GitHub issuePlease ensure:
- The bug is caused by Refined GitHub. It doesn’t happen if I disable the extension.
- The bug happens after clearing extension cache. The “Clear cache” button below can also be found at the bottom of the options page.
Example URLs
https://github.com/refined-github/refined-github/search?q=.rgh-minimize-upload-bar
Extension version
22.6.25
Browser(s) used
Firefox 101.0.1
Description
Clicking an issue number in a linkified reference in code in a search page will link you to https://issues/[number]
instead of to the issue.
No console errors other than failing to get the hovercard when hovering over the link.
Include in this issue:
- Screenshots/video/gif demonstrating the bug, if it’s visual
- Console errors, if any
Issue Analytics
- State:
- Created a year ago
- Comments:6 (6 by maintainers)
Top Results From Across the Web
Options · Documentation - Linkify - JS.ORG
Linkify is a JavaScript plugin. Use Linkify to find links in plain-text and convert them to HTML tags. It automatically highlights URLs, #hashtags, ......
Read more >Android linkify URLs links non URLs - regex - Stack Overflow
After much searching and trial and error, this is the solution. Do not use the default Linkiny.WEB_URLS. Use a custom regex pattern that...
Read more >linkify doesn't accept urls with underscores · Issue #38 - GitHub
Example One has to escape the underscores in the url but I don't think that this is the expected behavior.
Read more >Top 5 linkify-it Code Examples - Snyk
Learn more about how to use linkify-it, based on linkify-it code examples created from the most popular ways it is used in public...
Read more >HYPERLINK - Google Docs Editors Help
Syntax. HYPERLINK(url, [link_label]). url - The full URL of the link location enclosed in quotation marks, ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I think every single repo-related detection does not need to check isRepoSearch, except the generic
isRepo
.In the extension however, every explicit
isRepo
meanshasRepoHeader
. Maybe we can forbid the use ofisRepo
in the extension, also because I always found it too broad to begin with.hasRepoHeader
has clearer intentions.This was probably fixed by https://github.com/refined-github/github-url-detection/pull/131, the link now works!