Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Node 12+ required to run the extension locally

See original GitHub issue

Hello there,

just noticed that a recent change from https://github.com/sindresorhus/refined-github/pull/3171 is making the extension runable only on Node 12+.

I reckon this is coming from the use of Object.fromEntries in webpack.config.ts (i.e. https://github.com/sindresorhus/refined-github/blame/fe806803b0a6cc6e473e5e10d00a00fb5571a178/webpack.config.ts#L51 or https://github.com/sindresorhus/refined-github/blame/fe806803b0a6cc6e473e5e10d00a00fb5571a178/webpack.config.ts#L98).

I couldn’t see any mention of that requirement anywhere, so I wondered if it had been done on purpose? If it wasn’t, maybe it’s worth a note somewhere (or we could add an engines property in the package.json for example)?

Issue Analytics

State:
Created 3 years ago
Comments:7 (7 by maintainers)

Top GitHub Comments

1reaction

arnaudvallecommented, Jun 9, 2020

What can we do to close this issue?

To me, a simple Requirements section or notice somewhere on the contributing.md file would be enough. It’s just so people who’d like to contribute don’t get stuck because of that error. Maybe just before Notions?

I’m happy to open up a PR if you’re ok with that.

1reaction

buschescommented, Jun 8, 2020

We define the version we test against in CI

Actually we don’t, we just use the default of ubuntu-latest, currently 12.16

https://github.com/sindresorhus/refined-github/blob/master/.github/workflows/test.yml#L25

Top Results From Across the Web

Visual Studio Code to use node version specified by NVM

I have 6.9.2 installed locally. Even after switching to another version, from the OS X terminal (not the VS Code terminal), restarting VS...

Install Node.js, npm, and VS Code - IBM Developer

This tutorial shows you 3 different ways to install the Node.js runtime and the Node.js package manager, npm: from the Node.js download page ......

Extension Host - Visual Studio Code

Node.js - Extensions are running in a Node.js runtime. Used by the local and remote extension hosts. Extensions need a main entry file...

CommonJS modules | Node.js v19.3.0 Documentation

When a file is run directly from Node.js, require.main is set to its module . That means that it is possible to determine...

Extensions — JupyterLab 3.6.0b0 documentation

Source extensions require Node.js to rebuild JupyterLab and activate the extension. If you use conda with conda-forge packages, you can get Node.js with:....