`one-click-diff-options` doesn't apply as default
See original GitHub issuePlease ensure:
- The bug is caused by Refined GitHub. It doesn’t happen if I disable the extension.
Example URLs
https://github.com/depcheck/depcheck/pull/656/files
Browser(s) used
Chrome macOS latest
Description
It seems the diff default option is not set when using the one-click-diff-options
buttons:
- Click on the “unified diff” button when the default has already been set to Split diff
- Refresh the page
- The Split diff appears again
On the main GitHub website (with the “Diff view” dropdown), it does two requests - one POST and one GET.
Maybe the extension is not sending the first POST request?
![Screen Shot 2022-01-10 at 10 12 08](https://user-images.githubusercontent.com/1935696/148741631-9ad60e0b-10b1-4049-87eb-a027dea83d59.png)
![Screen Shot 2022-01-10 at 10 10 18](https://user-images.githubusercontent.com/1935696/148741536-e4481230-95fd-4957-a553-cbe30851bdaf.png)
Include in this issue:
- Screenshots/video/gif demonstrating the bug, if it’s visual
- Console errors, if any
Issue Analytics
- State:
- Created 2 years ago
- Comments:5 (5 by maintainers)
Top Results From Across the Web
Recent change to "Show Diff" from Git panel?
I recently updated to 2021.2 and just noticed this problem, but I'm unsure if I accidentally changed a setting or if it's a...
Read more >git - Unable to choose "Show Diff" option in Android Studio ...
Try opening the changed file(by using double-click or right click and choose "Show Diff") to see the difference made in that commit. Error...
Read more >Request double-click file to open External Diff not "Open File"
When clicking through files on that pane, because the lines are so close together, I am continually mistakenly double-clicking one line instead of...
Read more >About comparing branches in pull requests - GitHub Docs
Pull requests display diffs to compare the changes you made in your topic branch against the base branch that you want to merge...
Read more >WinCVS Tutorial (Part II)
Choose Admin->Preferences… from the menu and go to the WinCvs tab. Check the “External diff program:” box and use the browse button to...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Just tried #5977 out (extension version
22.9.15
) and it seems to be working, nice! Thanks for this @fregante !once again it’s haappeeniiiiing
@kidonng I think this kinda classifies as a bug since we’re breaking GitHub’s default behavior. It appears that the content of that dropdown is not loaded later, so we can “easily” use
await pushForm(select('diffview')) && location.reload()
. If the form is missing we can just let the regular link through and log an error to the console so that the feature doesn’t stop working.