Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`one-click-diff-options` doesn't apply as default

See original GitHub issue

Please ensure:

The bug is caused by Refined GitHub. It doesn’t happen if I disable the extension.

Example URLs

https://github.com/depcheck/depcheck/pull/656/files

Browser(s) used

Chrome macOS latest

Description

It seems the diff default option is not set when using the one-click-diff-options buttons:

Click on the “unified diff” button when the default has already been set to Split diff
Refresh the page
The Split diff appears again

On the main GitHub website (with the “Diff view” dropdown), it does two requests - one POST and one GET.

Maybe the extension is not sending the first POST request?

Include in this issue:

Screenshots/video/gif demonstrating the bug, if it’s visual
Console errors, if any

Issue Analytics

State:
Created 2 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

karlhorkycommented, Sep 15, 2022

Just tried #5977 out (extension version 22.9.15) and it seems to be working, nice! Thanks for this @fregante !

1reaction

fregantecommented, Jan 11, 2022

once again it’s haappeeniiiiing

@kidonng I think this kinda classifies as a bug since we’re breaking GitHub’s default behavior. It appears that the content of that dropdown is not loaded later, so we can “easily” use await pushForm(select('diffview')) && location.reload(). If the form is missing we can just let the regular link through and log an error to the console so that the feature doesn’t stop working.