question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`one-click-diff-options` removes the built-in diff options

See original GitHub issue

Description

I noticed today that the built-in GitHub diff options on the “Files” tab of a pull request were no longer visible when one-click-diff-options was enabled.

I opened a PR that looked like this (some info redacted): image

Notice the “book” icon and the [•] icon, these are from the one-click-diff-options feature. But usually there are also a few more options from GitHub itself, such as “Changes from all commits…” (or a specific commit), “File filter…”, and “Jump to…”. These are now missing.

I used Refined GitHub’s “Start process to identify a feature” to pinpoint which feature was causing this issue. I went through all the steps and a pop-up said it was due to one-click-diff-options. When I disabled this feature, the built-in diff options came back.

With the feature disabled, the same page now looks like this, with the expected diff options: image

Regardless of whether the feature is enabled, I consistently see an error being logged (twice) in the console on the Files page where I noticed this issue. Both log messages are the same:

refined-github.js:5963 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'textContent')
    at isArchivedRepo (refined-github.js:5963:75)
    at refined-github.js:3941:95
    at Array.every (<anonymous>)
    at refined-github.js:3941:82
    at setupPageLoad (refined-github.js:3942:8)
    at refined-github.js:3987:35

This is preceded by two errors reported by different features (clean-repo-tabs and more-dropdown-links), so I’m not sure it’s relevant here but I’m including it just in case.

I tried the “Clear cache” suggestion, but it didn’t help. This happened with GitHub Enterprise Server.

How to replicate the issue

I am unable to provide a link, but I tried to reproduce the issue on GitHub.com and was unable to.

Extension version

22.7.11

Browser(s) used

Google Chrome version 104.0.5112.39 (Official Build) beta (x86_64)

Issue Analytics

  • State:closed
  • Created a year ago
  • Reactions:1
  • Comments:11 (6 by maintainers)

github_iconTop GitHub Comments

2reactions
fregantecommented, Jul 15, 2022

Hello, it’s me, I broke your GHE in https://github.com/refined-github/refined-github/pull/5518 👋 😅

0reactions
fregantecommented, Oct 7, 2022

Related, we had the same issue last December:

Read more comments on GitHub >

github_iconTop Results From Across the Web

Disable broken one-click-diff-options on GitHub Enterprise ...
For one-click-diff-options removes the built-in diff options #5820. The feature actively breaks GitHub's UI on Enterprise, so I had to disable it there....
Read more >
diff Options (Comparing and Merging Files)
Ignore changes that just insert or delete blank lines. See Suppressing Differences Whose Lines Are All Blank. --binary. Read and write data in...
Read more >
Git - git-difftool Documentation
Run git difftool --tool-help for the list of valid <tool> settings. If a diff tool is not specified, ... The list below shows...
Read more >
p4 diff2
p4 diff2. Diff utility for comparing the content at two depot paths. (For comparing workspace content to depot content, see p4 diff.).
Read more >
External Diff Tools | IntelliJ IDEA Documentation
File | Settings | Tools | Diff & Merge | External Diff Tools for Windows and Linux ... Remove the selected external tool....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found