`one-click-pr-or-gist`: In PR compare pages the "Create pull request" button is always enabled, even with empty title

Please ensure:

• The bug is caused by Refined GitHub. It doesn’t happen if I disable the extension.

Describe the problem and how to replicate it

Continuing https://github.com/sindresorhus/refined-github/pull/4556#issuecomment-879092209

In PR branch compare pages, e.g. https://github.com/darkred/test/compare/main...t2?expand=1, the “Create pull request” button is always enabled, even with empty title - (the expected behavior is to be disabled when the title is empty). Disabling the one-click-pr-or-gist feature fixes the problem.

See:

• the attached screen capture for the issue, and
• the screenshot for how it is (as expected) with the one-click-pr-or-gist feature disabled.

Screenshots/video/gif showing the issue, if it’s visual

Console errors, if any

No response

Example URL

https://github.com/darkred/test/compare/main...t2?expand=1

Browser(s) used

Chrome 91, Firefox 90

[fregante]

1. If GitHub allows an empty body, we allow the empty body, and vice versa. In short just add the attribute and that’s it.
2. What you mentioned about the attribute is just lint stuff that you can avoid discussing, just follow the linter. My code suggestions in comments aren’t meant to be 100% exact as I don’t write them in my editor

[fregante]

Thanks for the research! The hook should be button[data-disable-invalid], our button does not have that: https://github.com/sindresorhus/refined-github/blob/ae247fb90a4c4b20524d76c823e97af3881326fb/source/features/one-click-pr-or-gist.tsx#L31

In this case, it should be as easy as adding the attribute

 <button
 	className={classList.join(' ')}
 	aria-label={description}
 	type="submit"
 	name={radioButton.name}
 	value={radioButton.value}
+	data-disable-invalid
 >
 	{title}
 </button>,

or maybe

+	data-disable-invalid={true}