question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`open-all-notifications` should also visible when i select some notifications

See original GitHub issue

Summary

  • show the open-notifications-button when i select the checkbox on a notification

Where

What i see

  • when i not select acheckbox - the button open-notifications-button
  • when i select a checkbox - the button open-notifications-button

What i Expect

  • the button open-notifications-button should also visible when i select checkboxes

Screenshots

Bildschirmfoto 2020-08-26 um 21 15 07 Bildschirmfoto 2020-08-26 um 21 15 16

PoC

Bildschirmfoto 2020-08-26 um 21 18 34

Modifications

a) Show a second Button Open Selected

a add a second button, like the current button it can visible/hidden with css

b) change to get the selected notifications

depending on the button clicked the selection of notification can handled different (adding a data-selection-type="all" /data-selection-type="selected" to distinct the buttons

c) edge cases

hide the button, when a user clicks on “select all” and then on “select all 20.212 notifications” (selected counter is > count of checkboxes on the page)

current behavior:

Bildschirmfoto 2020-08-26 um 21 23 10 Bildschirmfoto 2020-08-26 um 21 23 21

Environment

Chrome: Version 84.0.4147.135 (Offizieller Build) (64-Bit) Refined GitHub: 20.8.16

Related issues

  • issue #3487 PR #3488 batch-open-conversations add checkboxes to repo without read access`

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:2
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
fregantecommented, Jul 16, 2021

a separate button handled by select-notifications?

The two are unrelated, one can select notifications without that button, even by clicking “All”

While technically it would be a separate button from “Open unread notifications”, it still matches that feature and name almost exactly, except it defaults to “open unread

1reaction
fregantecommented, Jul 8, 2021

select-notifications has been implemented by @cheap-glitch now ☺️

Read more comments on GitHub >

github_iconTop Results From Across the Web

Use notifications on your iPhone or iPad - Apple Support
Tap a single notification to open the app that it's from. Tap a group of notifications to view all recent notifications from that...
Read more >
Control notifications on Android - Google Support
Open your phone's Settings app. ... Notifications. Under “Recently Sent,” tap an app. Tap a type of notification. Choose your options: Choose Alerting...
Read more >
Change notification and quick settings in Windows
Select Notifications to expand it, and turn notifications, banners, and sounds on or off for some or all notification senders. Scroll down and...
Read more >
Notifications Overview | Android Developers
You can programmatically set the level of detail visible in notifications posted by your app on a secure lock screen, or even whether...
Read more >
Control notifications on your Galaxy phone or tablet - Samsung
You can manage your device's notifications right from the Lock screen by adjusting the Lock screen settings and other display settings.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found