question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

PR approval counts not visible anymore

See original GitHub issue

In the v21.2.23 the PR approval count is not displayed correctly anymore: Screenshot 2021-03-01 at 12 29 51

This is how it looked until a couple of days ago (don’t know exactly when it “broke”) Screenshot 2021-03-01 at 16 25 42

This is the CSS that should do this: https://github.com/sindresorhus/refined-github/blob/main/source/features/pr-approvals-count.css

I am running this setup:

  • MS Edge Version 88.0.705.81 (Official build) (64-bit)
  • Refined GitHub 21.2.23

There is no error in the JS-console that correlates to this. Although I do see some other non-related errors, but I do not want to bring them up here. I am just adding the errors here, to show what they are!!! Screenshot 2021-03-01 at 12 32 57

PS: I disabled the features that are throwing the JS-console errors:

  • clean-conversation-filters
  • highlight-non-default-base-branch

Outcome is still the same - approval count not displayed.

PPS: Source of this feature: https://github.com/sindresorhus/refined-github/pull/816

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:1
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

2reactions
cheap-glitchcommented, Mar 1, 2021

This was fixed by #4021 and should be released soon.

0reactions
fregantecommented, Mar 2, 2021

No worries, thanks for the detailed report Lutz!

PS: Do you still see those errors on the new version? We fixed a lot of bugs in this version.

Read more comments on GitHub >

github_iconTop Results From Across the Web

pr created not seen at the approval person. - SAP Community
Dear Consultants,. We have created a PR with t-code ME51N & it is completed & saved with a PR no. 5000012345. The problem...
Read more >
Why are my contributions not showing up on my profile?
Learn common reasons that contributions may be missing from your contributions graph. ... Contributions are only counted if they meet certain criteria.
Read more >
Display Approval count when approval is requested.
Hello,. I want the "Approvals" menu item to be shown at all times, and I want the approval count to be visible when...
Read more >
Approval of required Reviewer does not allow to Complete ...
Hi,. I have a Problem with Azure DevOps, I'm a required reviewer, when I create a PR I can't complete it without adding...
Read more >
What are the residency requirements for permanent residents ...
Immigration, Refugees and Citizenship Canada no longer issues Returning Resident Permits. If you plan to apply for Canadian citizenship, please ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found