question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

PR diff indentation broken

See original GitHub issue

Hi! I’ve ran into a bug where Refined GitHub causes a problem with the indention in pull request diffs. I tried to look through the recent changelog as the issue happened, for me, between last Friday and this Monday. I restarted my computer and thus my browser for the first time in ~7 days this weekend as well. So I assume an update to Refined GitHub might have been applied.

This is on a private GitHub Enterprise 2.16.9 deployment. The URL to the page is something like (private components redacted): https://<host>/<org>/<repo>/pull/128/files

With Refined GitHub I see: With Refined GitHub

When disabling the extension the text is indented correctly: Vanilla GitHub


It seems like it might be related to some text-indent changes? E.g. https://github.com/sindresorhus/refined-github/pull/2088 . However tried disabling indented-code-wrapping as suggested in that issue but the indentation was still broken.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:3
  • Comments:15 (8 by maintainers)

github_iconTop GitHub Comments

2reactions
NickCravercommented, Jun 25, 2019

The content is double-indented in the second screenshot. I’m seeing the same thing in our GitHub instance over at Stack as well.

1reaction
tknickmancommented, Jun 25, 2019

Ah that looks like it. I can see the fix is working when adding display: block to the span.blob-code-inner elements. However if I add the rgh-code-wrapping-enabled class to the table, I don’t get the changes.

I am also seeing other missing css (I have the exact issue described in https://github.com/sindresorhus/refined-github/issues/2174 and I’m just now noticing that I don’t have other adjustments like the left aligned labels in the pr view anymore).

So looks like this is just GHE missing css.

Read more comments on GitHub >

github_iconTop Results From Across the Web

PR diff indentation broken · Issue #2171 - GitHub
Hi! I've ran into a bug where Refined GitHub causes a problem with the indention in pull request diffs. I tried to look...
Read more >
Indentation issue in the pull request - git - Stack Overflow
I am a beginner in Git and GitHub. There's an issue that I am facing. I made changes in a separate branch and...
Read more >
Tabs and indents settings does not work
I have a problem with tab and indents settings. In settings->codestyle->php->tabs&indents I have set tab character for indent.
Read more >
Ability to ignore whitespace changes in the diffs (BB-11120)
I would like to see the option to ignore space changes in the diff viewer as well. It allows us to focus on...
Read more >
Pretty Diff - The difference tool
Pretty Diff tool can minify, beautify (pretty-print), or diff between minified and beautified code. This tool can even beautify and minify React JSX...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found