question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Projects Tab Still Visible on GHE

See original GitHub issue

For some reason GHE has the class name on the span as counter instead of Counter, meaning we don’t find the count and don’t remove the tab. Can we search for the span instead or just ounter with projectsTab.find('span[class$="ounter"]')?

Current code: https://github.com/sindresorhus/refined-github/blob/master/extension/content.js#L354-L359

function removeProjectsTab() {
 	const projectsTab = $('.js-repo-nav').find('.reponav-item[data-selected-links^="repo_projects"]');
 	if (projectsTab.length > 0 && projectsTab.find('.Counter').text() === '0') {
 		projectsTab.remove();
 	}
 }

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:1
  • Comments:11 (11 by maintainers)

github_iconTop GitHub Comments

1reaction
hkdobrevcommented, May 12, 2017

I’ll insist on supporting GHE even though I’m not using GHE myself.

Users of GHE are often power users and are the customers paying the most to GitHub, so this would make GitHub take changes from the extension even more seriously if enterprise customers are adding a browser extension to extend GH functionality.

@sindresorhus

I’m willing to do it if someone using GHE wants to join the project. If not, it’s pretty hopeless for us to fix issues that come up.

@busches has already contributed and is a GHE user. We also have others like @bfred-it, I think. Perhaps he could try to tackle the GHE support so even more GHE users join in the future.


On the actual issue, I think this is pretty minor and the effort to fix it is significantly lower than the benefit.

I’d rather look for .Counter, .counter than span[class$="ounter"]

👍


@busches Could you open a PR for the Projects tabs with the suggestion from @jgierer12? I guess you’d test whether it works on GHE.

0reactions
fregantecommented, May 26, 2017

@hkdobrev Side note: I’m not a GHE user 😄

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to make "Projects" Tab visible - Trailhead - Salesforce
Setup > Customize > Partners > Settings > Find your portal name > Click "Customize Portal Tabs" button. Once you'd added the projects...
Read more >
Projects Missing/Not Showing Up in Projects Tab
Projects Missing/Not Showing Up in Projects Tab · 1. Click on "More Views" and select "Edit Current View". · 2. On the first...
Read more >
I upgraded to Plus, but still don't see Projects tab ... - QuickBooks
I have troubleshooting steps to make the Project feature visible in your account. ... The Project tab is located on the upper left...
Read more >
the 'Projects' tab/dropdown menu is not showing
Solved: I added an user that works not within our company but for one of our customers and added him to the necessary...
Read more >
Projects tab is not visible - ArtCAM Community
Projects tab is not visible. I am currently using version 2017 Service Pack 6. The project panel has disappeared from the work space...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found