`quick-comment-edit` appears on other users' comments in issues

Please ensure:

• The bug is caused by Refined GitHub. It doesn’t happen if I disable the extension.

Description

Open an issue, e.g.: https://github.com/facebook/jest/issues/6316 and scroll through the comments in the conversations tab. You will see edit buttons on all comments, including comments from other users. When you click on the edit button, you see an error message: Sorry, something went wrong.

Console errors

A 403 Forbidden when the page attempts to retrieve the edit form for that comment:

XHR GET https://github.com/facebook/jest/issue_comments/.../edit_form?textarea_id=issuecomment-...-body&comment_context= [HTTP/2 403 Forbidden 321 ms]

Example URL

https://github.com/facebook/jest/issues/6316 (locked issue) https://github.com/facebook/jest/issues/11791 (regular issue)

Browser(s) used

Firefox

[fregante]

There’s a variety of signals we can use to determine whether the current user can edit every comment, it’s just a matter of finding them in each supported page.

Example:

• Can I edit the issue/PR sidebar?
• Can I edit the title even if I’m not the author?
• Is there a settings tab? (only for the owner)
• Is there a “you are a collaborator” anywhere on the page?

However I also see an element that’s missing from the Jest conversation:

but is available in this repo:

So maybe we should look for that in every comment:

js-previewable-comment-form previewable-comment-form write-selected

Even if this only works on some pages, it’s better than showing a broken element for now.

[gamemaker1]

I see the ('[data-url$="variables%5BdeferredEditForm%5D=false"]') on your comment just now too - but I should not be able to edit your comment right?

Edit: Even my own comments seem to have that variable, and it is set to false