Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`selection-in-new-tab` should not be enabled everywhere

See original GitHub issue

selection-in-new-tab is enabled on every page and it attaches a keypress handler even when not necessary. At the very least, this feature should be limited to places with navigations using include, like isRepoConversationList, isRepoTree and isNotifications

Are there any other pages where this feature applies?

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

shinenelsoncommented, Aug 20, 2021

This issue has been open for too long. It looks like an easy change. Should we leave it longer for someone new to come along and pick it up? Or shall I pick it up?

yakov116commented, Apr 23, 2021

close-out-of-view-modals hide-navigation-hover-highlight improve-shortcut-help linkify-user-location navigate-pages-with-arrow-keys parse-backticks profile-hotkey reload-failed-proxied-images selection-in-new-tab set-default-repositories-type-to-sources user-local-time

⬆️ ⬆️ ⬆️ ⬆️ ⬆️ ⬆️ ⬆️ ⬆️

Those are the features that are global.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Network Configuration for Listen Everywhere
*. • Enable Multicast UDP (i.e. mDNS, Bonjour, Avahi) (see Enabling Multicast UDP). • Use an open network (no encryption). Using encryption can...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found