question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Shortcut for approving merged pull requests

See original GitHub issue

Often times I’m still reviewing pull requests that have been merged already. It would be nice if there would an approve button.

Currently it looks like this:

screenshot from 2018-08-09 14-07-25

Maybe a button next to Submit review that is called Approve and when clicked will insert :+1: into the textfield and hit on the submit review button.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:4
  • Comments:6 (5 by maintainers)

github_iconTop GitHub Comments

5reactions
tshtatlandcommented, Dec 17, 2021

I had cases like the one described in the OP above, when the PR was merged before I approved it. I could not prevent the PR from being merged into master (this is as intended - my opinion is advisory only, not meant to prevent anyone from carrying out what is the best course of action). But there have been cases when I want to go back later and actually approve the PR after the branch was merged into master. This is, for example, for record keeping purposes, and for team communication purposes. We need to know and keep track of what was approved and not approved, and why. I could only find a way to comment that I approve. I could not find a way to approve and display the “<user name> approved these changes” icon in the UI.

5reactions
sindresorhuscommented, Nov 7, 2018

Thanks for the suggestion, but we’re going to pass on this 😃

Read more comments on GitHub >

github_iconTop Results From Across the Web

Shortcut for approving merged pull requests #1472 - GitHub
Often times I'm still reviewing pull requests that have been merged already. It would be nice if there would an approve button.
Read more >
Using Branches and Pull Requests with the Shortcut VCS ...
When a Story has a linked branch, you can open a new Pull Request from the Shortcut UI by clicking the "Open PR"...
Read more >
Merge a pull request | Bitbucket Cloud - Atlassian Support
When the desired number of reviewers have approved a pull request, you can merge the pull request if you have write (or admin)...
Read more >
Add shortcuts to go to specific issue or merge request directly
First the shortcut # is used to go to issue no. 4, then the shortcut ! is used to go to merge request...
Read more >
Working with Pull Requests in Visual Studio Code and GitHub
Pull requests let your team give feedback on changes in feature branches before merging the code into the master branch. Reviewers can step ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found